Merge pull request #100 from input-output-hk/cad-2320-fix-node-commit…

…-link CAD-2320: fix Node commit href.
input-output-hk · Nov 24, 2020 · f03d23b · f03d23b
2 parents 1927d2a + 7d6aa5c
commit f03d23b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/src/Cardano/RTView/GUI/CSS/Style.hs b/src/Cardano/RTView/GUI/CSS/Style.hs
@@ -42,6 +42,10 @@ ownCSS = unpack . TL.toStrict . render $ do
   a # visited # hover ? do
     color             "#4b0082"
 
+  cl InactiveHref ? do
+    pointerEvents     none
+    cursor            cursorDefault
+
   cl TopBar ? do
     backgroundColor   "#1b2238"
     color             whitesmoke

diff --git a/src/Cardano/RTView/GUI/Elements.hs b/src/Cardano/RTView/GUI/Elements.hs
@@ -150,6 +150,7 @@ data HTMLClass
   | GridRowCell
   | HSpacer
   | IdleNode
+  | InactiveHref
   | InfoMark
   | InfoMarkImg
   | MetricsArea
@@ -264,6 +265,7 @@ instance Show HTMLClass where
   show GridRowCell            = "GridRowCell"
   show HSpacer                = "HSpacer"
   show IdleNode               = "IdleNode"
+  show InactiveHref           = "InactiveHref"
   show InfoMark               = "InfoMark"
   show InfoMarkImg            = "InfoMarkImg"
   show MetricsArea            = "MetricsArea"

diff --git a/src/Cardano/RTView/GUI/Markup/Grid.hs b/src/Cardano/RTView/GUI/Markup/Grid.hs
@@ -227,9 +227,10 @@ mkNodeElements NodeState {..} nameOfNode elIdleNode acceptors = do
                  #+ []
 
   elNodeCommitHref
-    <- UI.anchor # set UI.href ""
+    <- UI.anchor #. [InactiveHref]
+                 # set UI.href ""
                  # set UI.target "_blank"
-                 # set UI.title__ "Browse cardano-node repository on this commit"
+                 # set UI.title__ ""
                  # set UI.text (showText nodeShortCommit)
 
   return $ HM.fromList

diff --git a/src/Cardano/RTView/GUI/Markup/Pane.hs b/src/Cardano/RTView/GUI/Markup/Pane.hs
@@ -145,9 +145,10 @@ mkNodePane nsTVar NodeState {..} nameOfNode acceptors = do
                                  ]
   elRTSMemoryProgressBox    <- UI.div #. [ProgressBarBox] #+ [element elRTSMemoryProgress]
 
-  elNodeCommitHref <- UI.anchor # set UI.href ""
+  elNodeCommitHref <- UI.anchor #. [InactiveHref]
+                                # set UI.href ""
                                 # set UI.target "_blank"
-                                # set UI.title__ "Browse cardano-node repository on this commit"
+                                # set UI.title__ ""
                                 # set UI.text (showText nodeShortCommit)
 
   -- Create content area for each tab.

diff --git a/src/Cardano/RTView/GUI/Updater.hs b/src/Cardano/RTView/GUI/Updater.hs
@@ -384,8 +384,10 @@ setNodeCommit
 setNodeCommit _ _ _ _ False _ _ = return ()
 setNodeCommit tv nameOfNode commit shortCommit True els elName =
   whenJust (els !? elName) $ \el -> do
-    void $ element el # set UI.href ("https://github.com/input-output-hk/cardano-node/commit/"
+    void $ element el #. []
+                      # set UI.href ("https://github.com/input-output-hk/cardano-node/commit/"
                                      <> unpack commit)
+                      # set UI.title__ "Browse cardano-node repository on this commit"
                       # set text (unpack shortCommit)
     setChangedFlag tv
                    nameOfNode