Commits on Jun 27, 2018

1. [CO-319] Fix account index swagger example

   

   akegalj authored and KtorZ committed Jun 27, 2018
   Copy the full SHA

   15ee1d5 View commit details

   Browse the repository at this point in the history

2. [CO-319] Add roundtrip tests

   

   akegalj authored and KtorZ committed Jun 27, 2018
   Copy the full SHA

   1208dcb View commit details

   Browse the repository at this point in the history

3. [CO-319] Fix recursive buildable instances

   

   akegalj authored and KtorZ committed Jun 27, 2018
   Copy the full SHA

   a06bb85 View commit details

   Browse the repository at this point in the history

4. [CO-319] Use strongly typed error

   

   parsonsmatt authored and KtorZ committed Jun 27, 2018
   Copy the full SHA

   76aedf8 View commit details

   Browse the repository at this point in the history

5. [CO-319] Remove duplication in 'renderAccountIndexError'

   

   KtorZ committed Jun 27, 2018
   Copy the full SHA

   43e6faa View commit details

   Browse the repository at this point in the history

6. [CO-319] Distangle V1/Errors …

   This makes it now possible to import V1/Errors from the V1/Types module and leverage errors from this module.
   One thing is still unclear to me: Why Errors isn't defined in V1/Types already?
   There's a circular dependency between V1/Response and V1/Types if we go this way, as well as between
   V1/Migration and V1/Types.
   Nevertheless, it would make sense to have three data-types here:
   
   - WalletError (defined in V1/Types)
   - MigrationError (defined in V1/Types)
   - JSONParsingError (defined in Response)
   
   This way, we could remove the conflicting constructor from WalletError and remove the need for an
   extra module here. It will also makes thing clearer

   

   KtorZ committed Jun 27, 2018
   Copy the full SHA

   88651af View commit details

   Browse the repository at this point in the history

7. [CO-319] Make V1/Error part of V1/Types …

   To realize this, we had to extract JSONValidationFailed and MigrationFailed constructor from WalletError.
   They're now defined as constructor in different data-types (resp. JSONValidationError and MigrationError).

   

   KtorZ committed Jun 27, 2018
   Copy the full SHA

   2813d97 View commit details

   Browse the repository at this point in the history

8. [CO-319] Solve rebase conflicts

   

   KtorZ committed Jun 27, 2018
   Copy the full SHA

   fd801a7 View commit details

   Browse the repository at this point in the history

9. [CO-319] Correctly format (jsend) newtype errors …

   This is rather ugly and could probably be achieved nicely with a better understanding of the
   Generics.SOP library. As far as I could tell, there's no easy way to retrieve 'Tag' for single
   constructor
   
   (cf: 'For a datatype with a single constructor we do not need to tag values with their constructor; but for a datatype with multiple constructors we do.  ')

   

   KtorZ committed Jun 27, 2018
   Copy the full SHA

   808f00b View commit details

   Browse the repository at this point in the history