This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-454] Correct window size when streaming blocks #3679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a node syncs with mainnet it maintains a window which controls
how many blocks the peer it syncs with is permitted to have outstanding.
The client incorrectly increased the window which, when the server
manages to send faster than the client was able to write to disk would
lead to a very large memory consumption until all blocks where written.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-454
Type of change
Developer checklist
Testing checklist
QA Steps
nix-build -A acceptanceTests.mainnet.full -o acceptance-test
./acceptance-test
Screenshots (if available)