Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata examples in swagger.yaml #2171

Merged
merged 1 commit into from Sep 23, 2020

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

Overview

  • 4a547f9
    Fix metadata examples in swagger.yaml

Comments

@piotr-iohk piotr-iohk added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Sep 23, 2020
@piotr-iohk piotr-iohk self-assigned this Sep 23, 2020
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui.

@KtorZ
Copy link
Member

KtorZ commented Sep 23, 2020

bors merge

iohk-bors bot added a commit that referenced this pull request Sep 23, 2020
2168: Remove Shelley specific transaction CLI tests from Jormungandr r=KtorZ a=piotr-iohk

# Issue Number

#2020

# Overview

- 5291da5
  Remove Shelley specific transaction CLI tests from Jormungandr



# Comments

Currently `TRANSMETA_CREATE_01 - Transaction with metadata via CLI` fails now on Jormungandr. Jormungandr has it's own (smaller) subset of CLI tx tests (also API tx tests) so, I think, it makes sense to remove core-integration tx CLI tests (which become more and more Shelley specific) from Jormungandr suite.


2171: Fix metadata examples in swagger.yaml r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 4a547f9
  Fix metadata examples in swagger.yaml



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 23, 2020

Build failed (retrying...):

iohk-bors bot added a commit that referenced this pull request Sep 23, 2020
2171: Fix metadata examples in swagger.yaml r=KtorZ a=piotr-iohk

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->


# Overview

- 4a547f9
  Fix metadata examples in swagger.yaml



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io>
@KtorZ KtorZ merged commit 0c9ce88 into master Sep 23, 2020
@KtorZ KtorZ deleted the piotr/fix-apidoc-metadata-examples branch September 23, 2020 14:42
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 23, 2020

Build failed:

#expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants