[ADP-2523] fix json encoding of StakePool to drop Null's #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
paolino/ADP-2523/fix-stake-pool-json-encoding
branch
from
b225d1e
to
9823fd7
Compare
paolino
force-pushed
the
paolino/ADP-2523/fix-stake-pool-json-encoding
branch
from
9823fd7
to
ca6296e
Compare
paolino
force-pushed
the
paolino/ADP-2523/fix-stake-pool-json-encoding
branch
from
ca6296e
to
637f2be
Compare
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
paolino/ADP-2523/fix-stake-pool-json-encoding
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
…drop Null's r=piotr-iohk a=paolino A patch to recover the old behavior. This was a breaking change that broke `Daedalus` client. `Maybe` encoding is always a problem. - [x] reencode Nothing as missing fields in `StakePool` instance - [x] bring back old golden tests with missing fields to verify the encoding. They were probably abandoned by mistake by renaming the ApiStakePool type to `ApiTStakePool` type in the code. A new ApiTStakePool.json instead was placed there that had no missing fields, so roundtrip tests missed the breaking change. - [x] add e2e test verifying there are no null values in the GET /stake-pools response ### Issue Number [ADP-2523] Co-authored-by: paolo veronelli <paolo.veronelli@gmail.com> Co-authored-by: Piotr Stachyra <piotr.stachyra@iohk.io> Source commit: c104a9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch to recover the old behavior.
This was a breaking change that broke
Daedalusclient.Maybeencoding is always a problem.StakePoolinstanceApiTStakePooltype in the code. A new ApiTStakePool.json instead was placed there that had no missing fields, so roundtrip tests missed the breaking change.Issue Number
ADP-2523