Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-2865] Add LastGC newtype to store POSIXTime in standard format. #3807

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[ADP-2865] Add LastGC newtype to store POSIXTime in standard format. #3807

merged 1 commit into from
Mar 23, 2023

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Mar 22, 2023 •
edited
Loading

  • fix POSIXTime Persistent codec

ADP-2865

@paolino paolino requested a review from piotr-iohk March 22, 2023 16:42
@paolino paolino self-assigned this Mar 22, 2023
@paolino paolino force-pushed the paolino/ADP-2865/wrap-posixtime-to-have-special-db-codec branch 3 times, most recently from 4a0c742 to b16b684 Compare March 23, 2023 09:45
@paolino paolino force-pushed the paolino/ADP-2865/wrap-posixtime-to-have-special-db-codec branch from b16b684 to 13ee4ce Compare March 23, 2023 09:48
piotr-iohk
piotr-iohk approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Issue no longer observed.

@paolino
Copy link
Collaborator Author

paolino commented Mar 23, 2023

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 23, 2023
@iohk-bors @paolino
Merge #3807
6db30ec 
3807: [ADP-2865] Add LastGC newtype to store POSIXTime in standard format. r=paolino a=paolino

- fix POSIXTime Persistent codec

ADP-2865


Co-authored-by: paolino <paolo.veronelli@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2023

Build failed:

@paolino
Copy link
Collaborator Author

paolino commented Mar 23, 2023

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 6f49a14 into master Mar 23, 2023
@iohk-bors iohk-bors bot deleted the paolino/ADP-2865/wrap-posixtime-to-have-special-db-codec branch March 23, 2023 11:03
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 23, 2023
docs: Merge #3807 3807: [ADP-2865] Add LastGC newtype to store POSIXT…
5090f84 
…ime in standard format. r=paolino a=paolino - fix POSIXTime Persistent codec ADP-2865
 Co-authored-by: paolino <paolo.veronelli@gmail.com> Source commit: 6f49a14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @piotr-iohk