Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt CompatibilitySpec goldens to use & test singleAddressFromKey #435

Merged
merged 1 commit into from Jun 19, 2019
Merged

Adapt CompatibilitySpec goldens to use & test singleAddressFromKey #435

merged 1 commit into from Jun 19, 2019

Conversation

Anviking
Copy link
Collaborator

Issue Number

#219

Overview

  • Make existing address golden tests use and test singleAddressFromKey

Comments

Successor to #433

@Anviking Anviking self-assigned this Jun 19, 2019
@Anviking Anviking mentioned this pull request Jun 19, 2019
Closed
1 task
paweljakubas
paweljakubas approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anviking Anviking merged commit bd92935 into master Jun 19, 2019
@Anviking Anviking deleted the anviking/219/adapt-goldens branch June 19, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anviking @paweljakubas