More tests for update passphrase via CLI #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
commented
Jul 12, 2019
| if (title == "40 chars hex") then | ||
| T.unpack err `shouldContain` | ||
| "I couldn't find a wallet with the given id:\ | ||
| \ 1111111111111111111111111111111111111111\n" |
There was a problem hiding this comment.
made small change so CLI checks if wallet exists before attempting to update pass (which is consistent with other endpoints behaviour)
this is tested here
KtorZ
approved these changes
Jul 12, 2019
| (ApiT wPassphraseOld) | ||
| (ApiT wPassphraseNew) | ||
| Left _ -> | ||
| handleResponse Aeson.encodePretty res |
| ] | ||
|
|
||
| (cTx, outTx, errTx) <- postTransactionViaCLI @t ctx pass args | ||
| expectations (cTx, outTx, errTx) |
There was a problem hiding this comment.
The test seems to be lesser than its title. We check that we can make a transaction with the new passphrase, but we don't actually check that a transaction cannot be made using the old passphrase, right ?
There was a problem hiding this comment.
but we don't actually check that a transaction cannot be made using the old passphrase, right ?
We do!
let matrix =
[ ("Old passphrase -> fail", oldPass
, expect (ExitFailure 1, mempty, errMsg403WrongPass)
)
, ("New passphrase -> OK", newPass
, expectTxOK
)
]
| , expect (ExitFailure 1, mempty, "passphrase is too short") | ||
| ) | ||
| , ( "Incorrect old passphrase", "wrong secure passphrase" | ||
| , expect (ExitFailure 1, mempty, errMsg403WrongPass) |
There was a problem hiding this comment.
I cringed when I saw the indentation on these two lines 😬
There was a problem hiding this comment.
take it easy ;) [will fix]
added 4 commits
July 12, 2019 16:47
…e (same as it is when posting tx or estimating fee or updating name)
piotr-iohk
force-pushed
the
piotr/update_pass_testing
branch
from
ee90d3e
to
a7c6028
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#472
Overview
Comments