Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move splitAtLastOccurrence from bech32 to text-class. #543

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Move splitAtLastOccurrence from bech32 to text-class. #543

merged 2 commits into from
Jul 16, 2019

Conversation

jonathanknowles
Copy link
Member

Issue Number

#466

Overview

A simple refactoring to facilitate further work on filtering transactions by date ranges.

I have:

  • moved splitAtLastOccurrence from bech32 to text-class.
  • fixed a problem with the Haddock documentation for this function.

@jonathanknowles jonathanknowles self-assigned this Jul 16, 2019
@KtorZ KtorZ mentioned this pull request Jul 16, 2019
Closed
11 tasks
@jonathanknowles jonathanknowles force-pushed the jonathanknowles/move-split-at-last-occurrence branch from fc659ca to b46100d Compare July 16, 2019 09:12
paweljakubas
paweljakubas approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move!

@paweljakubas paweljakubas force-pushed the jonathanknowles/move-split-at-last-occurrence branch from b46100d to 30b16c3 Compare July 16, 2019 11:06
@paweljakubas paweljakubas merged commit d571880 into master Jul 16, 2019
@paweljakubas paweljakubas deleted the jonathanknowles/move-split-at-last-occurrence branch July 16, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
Finalize 'Transactions' API endpoints
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanknowles @paweljakubas @KtorZ