Better structure for the internal organization of our state directory #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
approved these changes
Jul 18, 2019
rvl
previously requested changes
Jul 19, 2019
There was a problem hiding this comment.
I like that parent directories are created and there are by default separate state directories for each network of each backend.
But nesting 2 levels of subdirectories within the state dir will make deployment less convenient. We are also committing the same error as http-bridge does -- see how that causes an unnecessary nesting of directories.
I think we should change it to stateDirOption :: Parser (Maybe FilePath). Adjust the help string to say the default is $HOME/.cardano-wallet/BACKEND/$network. Then fill in the default value if the option was Nothing.
piotr-iohk
force-pushed
the
KtorZ/state-dir-namespace
branch
from
d5a14e1
to
df534c3
Compare
|
Meanwhile, I've adjusted the tests and added tests for nested dir state-dir. |
Such that our state dir looks nicer:
/home/ktorz/.cardano-wallet/
└── jormungandr
└── testnet
├── chain
│ ├── blocks.sqlite
│ ├── blocks.sqlite-shm
│ └── blocks.sqlite-wal
├── jormungandr-config.json
├── wallet.db
├── wallet.db-shm
└── wallet.db-wal
rvl
force-pushed
the
KtorZ/state-dir-namespace
branch
from
df534c3
to
4c18851
Compare
- Put the default --state-dir within the XDG data dir - Make --state-dir point to the actual state dir, rather than nesting directories within.
rvl
force-pushed
the
KtorZ/state-dir-namespace
branch
from
4c18851
to
ceaf74c
Compare
We do use 'mempty' often to align text and ease readability. So the small overhead is acceptable and, most probably removed by GHC at compile-time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#564
Overview
--state-dirwouldn't be created and fail in a not-so-user-friendly way:Comments