Move modules to make room for "random" AD scheme #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
approved these changes
Jul 25, 2019
| -- ensure that the following implementation matches with other wallet softwares | ||
| -- (like Yoroi/Icarus or the cardano-cli) | ||
| -- ensure that the implementations match with other Cardano wallets | ||
| -- (like cardano-sl, Yoroi/Icarus, or cardano-cli) |
There was a problem hiding this comment.
Updating the module level comments ✨
| -- schemes implemented are: | ||
| -- | ||
| -- * 'Cardano.Wallet.Primitive.AddressDiscovery.Sequential' | ||
| -- * 'Cardano.Wallet.Primitive.AddressDiscovery.Random' |
Anviking
force-pushed
the
rvl/553/ad-moving
branch
from
5fedcf7
to
0ead731
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #553
Overview
Cardano.Wallet.Primitive.Address{Derivation,Discovery}.{Random,Sequential}Cardano.Wallet.Primitive.Address{Derivation,Discovery}Comments
keyToAddresswill have slightly different parameters between Sequential and Random schemes. I haven't done anything to address that, and just left the parameters as they are for Sequential.