port kedqr to catalyst-toolbox #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkijania
approved these changes
May 31, 2021
|
Looks good. I will add flake.nix and flake.lock in different pr |
|
Needs rebasing. |
zeegomo
force-pushed
the
port-kedqr
branch
2 times, most recently
from
c5dff6d
to
e6fff19
Compare
mzabaluev
requested review from
mzabaluev
and removed request for
filip-dulic-bloxico
"kedqr" is meaningless, use qr-code. Correct Rust capitalization in data types that deal with QR codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to port to catalyst toolbox the functionalities of https://github.com/input-output-hk/vit-kedqr
What changed
QRPinmoved to the lib side, to have all tests in a single spacev0.5.0from symmetric cipher since it links to a version of cryptoxide that does not build anymoreWhat has not been ported