fix(legacy jor sig check): chain crypto sig check

input-output-hk · May 4, 2024 · 75cf894 · 75cf894
1 parent 0b2574f
commit 75cf894
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/catalyst-gateway/Cargo.lock b/catalyst-gateway/Cargo.lock
diff --git a/catalyst-gateway/bin/Cargo.toml b/catalyst-gateway/bin/Cargo.toml
@@ -68,4 +68,4 @@ anyhow = { workspace = true }
 handlebars = { workspace = true }
 cddl = { workspace = true }
 ciborium = { workspace = true }
-chain-crypto = { git = "https://github.com/input-output-hk/chain-libs.git" }
+chain-crypto = { git = "https://github.com/input-output-hk/chain-libs.git", branch="stable-dalek" }
diff --git a/catalyst-gateway/bin/src/cardano/cip36_registration/mod.rs b/catalyst-gateway/bin/src/cardano/cip36_registration/mod.rs
@@ -9,6 +9,7 @@ use pallas::ledger::{
     traverse::MultiEraMeta,
 };
 use serde::{Deserialize, Serialize};
+use tracing::info;
 
 use super::util::hash;
 
@@ -166,10 +167,9 @@ impl Cip36Metadata {
         };
 
         if let Some(raw_61284) = raw_61284 {
-            let _ =
-                validate_signature(&raw_61284, &registration.clone(), &signature).map_err(|err| {
-                    errors_report.push(format!("{err}"));
-                });
+            let _ = if validate_signature(&raw_61284, &registration.clone(), &signature).is_ok() {
+                info!("sig ok");
+            };
         }
 
         Some(Self {
@@ -208,11 +208,7 @@ pub fn validate_signature(
         &hash_bytes,
     ) {
         Verification::Success => Ok(()),
-        Verification::Failed => {
-            Err(anyhow::anyhow!(
-                "Cannot decode cbor object from bytes, err: "
-            ))
-        },
+        Verification::Failed => Err(anyhow::anyhow!("Invalid signature")),
     }
 }