Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Adds Rust CI/CD and Refactors Cataylst gateway to be passing (minus unit tests). #79

Merged
merged 41 commits into from
Oct 21, 2023

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Oct 20, 2023

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

This is currently linked to a pre-release of the rust tooling defined in catalyst-ci.
That will be changed in a separate PR once the upstream code merges.

Related Issue(s)

List the issue numbers related to this pull request.

Description of Changes

  • Add Earthly defined Rust CI Runners following convention agreed with @jmgilman
  • Refactors Cat-Data-Service into the first iteration of Catalyst Gateway
  • Makes all lints pass at the new strict levels. Code builds.

Breaking Changes

Tests currently do not pass since they are blocked on refactoring the DB setup.

See:

This should still be merged even with the tests broken, and they can be corrected in a followup.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

…ion by splitting into multiple logical units.
@stevenj stevenj requested a review from minikin October 20, 2023 12:28
@minikin minikin enabled auto-merge (squash) October 20, 2023 13:31
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenj
I've approved this PR.
Moving forward, I propose we aim for more concise PRs.
Smaller PRs can streamline the review process and save time for everyone involved

@minikin minikin merged commit cb5cfd4 into main Oct 21, 2023
3 checks passed
@minikin minikin deleted the feat/catalyst-gateway branch October 21, 2023 07:30
@minikin minikin mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Status: ✅ Done
2 participants