/action/{id}/runs: fix zero value Run displayed

input-output-hk · Jun 21, 2022 · 6b29ee2 · 6b29ee2
1 parent 4878fc1
commit 6b29ee2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/application/component/web/main.go b/src/application/component/web/main.go
@@ -399,7 +399,7 @@ func (self *Web) ActionIdRunGet(w http.ResponseWriter, req *http.Request) {
 						errChan <- err
 						return
 					} else {
-						entries[i].Run = &run
+						entries[i].Run = run
 					}
 				}(i, invocation.Id)
 			}
@@ -541,7 +541,7 @@ func (self *Web) InvocationIdGet(w http.ResponseWriter, req *http.Request) {
 			return
 		}
 	} else {
-		run = &run_
+		run = run_
 	}
 
 	var inputs map[string]domain.Fact
@@ -739,7 +739,7 @@ func (self *Web) RunGet(w http.ResponseWriter, req *http.Request) {
 					if run, err := self.RunService.GetByInvocationId(id); err != nil && !pgxscan.NotFound(err) {
 						errChan <- err
 					} else if err == nil {
-						entries[i].Run = &run
+						entries[i].Run = run
 					}
 				}(i, invocation.Id)
 			}
@@ -867,7 +867,7 @@ func (self *Web) ApiRunByInputGet(w http.ResponseWriter, req *http.Request) {
 				self.ServerError(w, err)
 				return
 			} else {
-				runs[i] = &run
+				runs[i] = run
 			}
 		}
 

diff --git a/src/application/service/run.go b/src/application/service/run.go
@@ -30,7 +30,7 @@ type RunService interface {
 
 	GetByNomadJobId(uuid.UUID) (domain.Run, error)
 	GetByNomadJobIdWithLock(uuid.UUID, string) (domain.Run, error)
-	GetByInvocationId(uuid.UUID) (domain.Run, error)
+	GetByInvocationId(uuid.UUID) (*domain.Run, error)
 	GetByActionId(uuid.UUID, *repository.Page) ([]*domain.Run, error)
 	GetLatestByActionId(uuid.UUID) (domain.Run, error)
 	GetAll(*repository.Page) ([]*domain.Run, error)
@@ -98,7 +98,7 @@ func (self runService) GetByNomadJobIdWithLock(id uuid.UUID, lock string) (run d
 	return
 }
 
-func (self runService) GetByInvocationId(invocationId uuid.UUID) (run domain.Run, err error) {
+func (self runService) GetByInvocationId(invocationId uuid.UUID) (run *domain.Run, err error) {
 	self.logger.Trace().Str("invocation-id", invocationId.String()).Msg("Getting Runs by input Fact IDs")
 	run, err = self.runRepository.GetByInvocationId(invocationId)
 	err = errors.WithMessagef(err, "Could not select Runs by Invocation ID %q", invocationId)

diff --git a/src/domain/repository/run.go b/src/domain/repository/run.go
@@ -12,7 +12,7 @@ type RunRepository interface {
 
 	GetByNomadJobId(uuid.UUID) (domain.Run, error)
 	GetByNomadJobIdWithLock(uuid.UUID, string) (domain.Run, error)
-	GetByInvocationId(uuid.UUID) (domain.Run, error)
+	GetByInvocationId(uuid.UUID) (*domain.Run, error)
 	GetByActionId(uuid.UUID, *Page) ([]*domain.Run, error)
 	GetLatestByActionId(uuid.UUID) (domain.Run, error)
 	GetAll(*Page) ([]*domain.Run, error)

diff --git a/src/infrastructure/persistence/run.go b/src/infrastructure/persistence/run.go
@@ -35,10 +35,10 @@ func (a runRepository) GetByNomadJobIdWithLock(id uuid.UUID, lock string) (run d
 	)
 }
 
-func (a runRepository) GetByInvocationId(invocationId uuid.UUID) (run domain.Run, err error) {
+func (a runRepository) GetByInvocationId(invocationId uuid.UUID) (run *domain.Run, err error) {
 	return run, pgxscan.Get(
-		context.Background(), a.DB, &run,
-		`SELECT * FROM run WHERE invocation_id = $1 `,
+		context.Background(), a.DB, run,
+		`SELECT * FROM run WHERE invocation_id = $1`,
 		invocationId,
 	)
 }