Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project.buildProject #1265

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Add project.buildProject #1265

merged 4 commits into from
Oct 11, 2021

Conversation

hamishmack
Copy link
Collaborator

This exposes the project used by buildModules.

@hamishmack
Add project.buildProject
326f50a 
This exposes the project used by `buildModules`.
@hamishmack hamishmack requested a review from jbgi October 11, 2021 06:09
@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Oct 11, 2021
@iohk-bors
Try #1265:
86084d5
@hamishmack
Copy link
Collaborator Author

This will be handy for adding ghcjs support to plutus. The buildProject for plutus ghcjs on linux and the native linux project have different materializations. With this change we can get the correct updateMaterialized script with project.buildProject.plan-nix.passthru.updateMaterialized (where project is the ghcjs project).

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2021

try

Build failed:

jbgi
jbgi suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@jbgi jbgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simplifications, if possible.

overlays/haskell.nix Outdated Show resolved Hide resolved
overlays/haskell.nix Outdated Show resolved Hide resolved
hamishmack and others added 2 commits October 11, 2021 22:07
@hamishmack @jbgi
Update overlays/haskell.nix
3639c61 
Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
@hamishmack @jbgi
Update overlays/haskell.nix
04a4628 
Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Oct 11, 2021
@iohk-bors
Try #1265:
3679a0d
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Oct 11, 2021
@iohk-bors
Try #1265:
3de22b1
@hamishmack hamishmack merged commit 2b5ad5a into master Oct 11, 2021
@iohk-bors iohk-bors bot deleted the hkm/build-project branch October 11, 2021 10:38
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 11, 2021

try

Build succeeded:

booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
@hamishmack @jbgi @booniepepper
Add project.buildProject (input-output-hk#1265)
540136b 
* Add project.buildProject

This exposes the project used by `buildModules`.

* Update overlays/haskell.nix

Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>

* Update overlays/haskell.nix

Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>

* Fix syntax error

Co-authored-by: Jean-Baptiste Giraudeau <jean-baptiste.giraudeau@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbgi jbgi jbgi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hamishmack @jbgi