Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for benchmarks and hspec-discover #181

Merged
merged 3 commits into from
Oct 1, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jun 15, 2019

This adds test cases for two bugs:

  1. benchmarks don't build (fixed in builder: Install benchmarks properly #175)

  2. If the cabal package has a test-suite with build-tools: hspec-discover, then cabal will not work in the development shell:

    # cabal new-configure --enable-tests
    Resolving dependencies...
    cabal: Could not resolve dependencies:
    [__0] trying: project-0.1.0.0 (user goal)
    [__1] rejecting: project:!test (constraint from config file, command line
    flag, or user target requires opposite flag selection)
    [__1] trying: project:*test
    [__2] next goal: project:hspec-discover:exe.hspec-discover (dependency of
    project *test)
    [__2] rejecting:
    project:hspec-discover:exe.hspec-discover-2.7.1/installed-EHO... (does not
    contain executable 'hspec-discover', which is required by project *test)
    [__2] fail (backjumping, conflict set: project,
    project:hspec-discover:exe.hspec-discover, project:test)
    After searching the rest of the dependency tree exhaustively, these were the
    goals I've had most trouble fulfilling: project, project:test,
    project:hspec-discover:exe.hspec-discover   
    

    The tests component builds fine, because hspec-discover is provided in the PATH.

    But I think the build-tools which are haskell packages need to be added into the package database for shells.

@rvl rvl added the bug Something isn't working label Jun 15, 2019
@rvl rvl self-assigned this Jun 15, 2019
@rvl rvl force-pushed the rvl/tests-benchmarks-hspec-discover branch from b19496f to 5fcf2ee Compare June 18, 2019 12:02
@angerman
Copy link
Collaborator

@rvl I somehow completely missed that. Can we rebase it and merge it? Should we disable the tests?

@rvl rvl force-pushed the rvl/tests-benchmarks-hspec-discover branch from 5fcf2ee to 8a8242e Compare July 15, 2019 02:14
@rvl
Copy link
Contributor Author

rvl commented Jul 15, 2019

This PR adds regression tests for two bugs. I fixed one of them, but haven't figured out the other one yet.

@angerman
Copy link
Collaborator

I'm really tempted to merge this @rvl, even if that means we have a broken test? Can we disable that for now with a comment?

@rvl
Copy link
Contributor Author

rvl commented Aug 28, 2019

OK if you want to merge I have removed the attempted fix and opened an issue #231.

@angerman angerman merged commit 53c0498 into master Oct 1, 2019
@angerman angerman deleted the rvl/tests-benchmarks-hspec-discover branch October 1, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants