Fetch stack.yaml extra-packages git submodules #2066
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to pull in a fork of
proto-lens
that I'm working on to ensure that it worked for an upstream project, and found that it failed to buildproto-lens-protbuf-types
due to a dependency on a submodule. When usingstack
directly, it always fetches submodules, so this PR updates calls to fetchGit forstack
to do the same:To repro: add this stanza to a
stack.yaml
and depend onproto-lens-protobuf-types
in the Haskell package. Without this PR, it'll fail because the.proto
files are used directly from the official Google protobuf repo by cloning it as a submodule.With this PR, that issue doesn't crop up. Unfortunately, I run into a different issue, which is:
So I guess unrelated to the exact change of this PR, can anyone help me understand how to override
buildInputs
and other details of the packages being pulled in from thestack.yaml
?