Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch stack.yaml extra-packages git submodules #2066

Closed
wants to merge 1 commit into from

Conversation

iand675
Copy link

@iand675 iand675 commented Sep 22, 2023

I attempted to pull in a fork of proto-lens that I'm working on to ensure that it worked for an upstream project, and found that it failed to build proto-lens-protbuf-types due to a dependency on a submodule. When using stack directly, it always fetches submodules, so this PR updates calls to fetchGit for stack to do the same:

To repro: add this stanza to a stack.yaml and depend on proto-lens-protobuf-types in the Haskell package. Without this PR, it'll fail because the .proto files are used directly from the official Google protobuf repo by cloning it as a submodule.

extra-deps:
- git: git@github.com:iand675/proto-lens.git
  commit: 38b1ab1d6785c36694245b19ce6a85ee6869b04a
  subdirs:
  - proto-lens
  - proto-lens-protoc
  - proto-lens-protobuf-types
  - proto-lens-runtime
  - proto-lens-setup
  - proto-lens-json

With this PR, that issue doesn't crop up. Unfortunately, I run into a different issue, which is:

Error: couldn't find the executable "protoc" in your $PATH.
   Follow the installation instructions at https://google.github.io/proto-lens/installing-protoc.html .

So I guess unrelated to the exact change of this PR, can anyone help me understand how to override buildInputs and other details of the packages being pulled in from the stack.yaml?

@angerman
Copy link
Collaborator

@iand675 sorry for the late reply. Can you try to merge master into your branch? I'll admit that our stack support is a bit lagging, as we don't have any active stack users at IOG anymore.

Copy link

stale bot commented Apr 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 19, 2024
@stale stale bot closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants