Refactoring test/default.nix #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdepillabout
commented
Feb 4, 2020
Comment on lines
-17
to
-21
| } // pkgs.lib.optionalAttrs (ifdLevel > 1) ( | ||
| builtins.mapAttrs (_: y: withIfdInputs y) ((if ifdLevel < 3 | ||
| then builtins.mapAttrs (_: d: pkgs.recurseIntoAttrs (pkgs.lib.filterAttrs (n: _: n == "ifdInputs") d)) | ||
| else x: x) { | ||
| cabal-simple = haskell-nix.callPackage ./cabal-simple { inherit util; }; |
There was a problem hiding this comment.
Aside from some simple formatting changes, this PR basically just pulls out each part of this code block into separate functions, and adds documentation describing what each does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #427, I was trying to figure out how the tests work. I ended up refactoring a bunch of the code in
test/default.nix.I pulled some things out into separate functions, as well as adding documentation. I didn't change any functionality.
cc @angerman @hamishmack