New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Rust API): Implement Rust Cron Module #124
Conversation
5f41a0e
to
4ee5709
Compare
a181d02
to
1b9e23a
Compare
1b9e23a
to
f9f87a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to move all internal cron logic as like mkdelay_crontab
, mkcron_impl
etc. out of the host.rs
? Like it is already done for hash
runtime extensions https://github.com/input-output-hk/hermes/blob/main/hermes/bin/src/runtime_extensions/hermes/hash/host.rs.
Also I think it is needed to add some unit tests for such functions as mkcron_impl
, cron_time_to_cron_sched
etc.
It should be ready to go. |
1cf13b6
to
fb7d941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds implementation of Rust Cron Module.
Related Issue(s)
List the issue numbers related to this pull request.
Closes #93
Description of Changes
cron
API methods with documentation.Please confirm the following checks