Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Rust API): Implement Rust Cron Module #124

Merged
merged 32 commits into from Feb 20, 2024
Merged

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Feb 11, 2024

Description

Adds implementation of Rust Cron Module.

Related Issue(s)

List the issue numbers related to this pull request.

Closes #93

Description of Changes

  • Adds a state to store and manage crontabs
  • Implements all of the cron API methods with documentation.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@saibatizoku saibatizoku changed the title [WIP] feat: Implement Rust Cron Module feat(Rust API): Implement Rust Cron Module Feb 15, 2024
@saibatizoku saibatizoku removed the draft Draft label Feb 15, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to move all internal cron logic as like mkdelay_crontab, mkcron_impl etc. out of the host.rs ? Like it is already done for hash runtime extensions https://github.com/input-output-hk/hermes/blob/main/hermes/bin/src/runtime_extensions/hermes/hash/host.rs.

Also I think it is needed to add some unit tests for such functions as mkcron_impl, cron_time_to_cron_sched etc.

@saibatizoku
Copy link
Contributor Author

Does it make sense to move all internal cron logic as like mkdelay_crontab, mkcron_impl etc. out of the host.rs ? Like it is already done for hash runtime extensions https://github.com/input-output-hk/hermes/blob/main/hermes/bin/src/runtime_extensions/hermes/hash/host.rs.

Also I think it is needed to add some unit tests for such functions as mkcron_impl, cron_time_to_cron_sched etc.

It should be ready to go.

@saibatizoku saibatizoku enabled auto-merge (squash) February 19, 2024 01:29
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saibatizoku saibatizoku merged commit 68081f4 into main Feb 20, 2024
27 checks passed
@saibatizoku saibatizoku deleted the feat/cron-api-rust branch February 20, 2024 07:29
@saibatizoku saibatizoku restored the feat/cron-api-rust branch February 21, 2024 23:29
@saibatizoku saibatizoku deleted the feat/cron-api-rust branch February 21, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Chronological Event utility API (Cron): Hermes Implementation (Rust Module)
3 participants