Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cron api rust): Implement Cron Events Rust #145

Merged
merged 62 commits into from Apr 2, 2024
Merged

Conversation

saibatizoku
Copy link
Contributor

@saibatizoku saibatizoku commented Feb 22, 2024

Description

Adds the implementation of a thread-safe Cron Event Queue as a Hermes Runtime Extension.

Related Issue(s)

List the issue numbers related to this pull request.

Closes #146

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need tor emove all uses of expect outside the unit tests.
I say in the comments to log. We haven't got a logging infrastructure in hermes yet, but you can put a line where we would log as a comment with a TODO to add logging, and tag the ticket for adding logging to hermes which is #15

Also need to properly add handling for the response to the on_cron event.

hermes/bin/src/runtime_extensions/hermes/cron/state.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime_extensions/hermes/cron/state.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime_extensions/hermes/cron/mod.rs Outdated Show resolved Hide resolved
@saibatizoku saibatizoku added the review me PR is ready for review label Mar 27, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Mar 28, 2024
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin enabled auto-merge (squash) April 2, 2024 07:14
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin disabled auto-merge April 2, 2024 07:33
@minikin minikin merged commit 00e6726 into main Apr 2, 2024
23 checks passed
@minikin minikin deleted the feat/cron-api-rust branch April 2, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Cron Event Service
4 participants