New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cron api rust): Implement Cron Events Rust #145
Conversation
921b9fe
to
d2f6128
Compare
3da96e1
to
dfde310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tor emove all uses of expect
outside the unit tests.
I say in the comments to log. We haven't got a logging infrastructure in hermes yet, but you can put a line where we would log as a comment with a TODO to add logging, and tag the ticket for adding logging to hermes which is #15
Also need to properly add handling for the response to the on_cron
event.
Refactor hermes::cron::State to implement CRUD methods to manage crontabs
* tidy up comments
c8f5c7b
to
b5e034f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use HashSet instead of BTreeSet for app_name list
d18434b
to
f79ee8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds the implementation of a thread-safe Cron Event Queue as a Hermes Runtime Extension.
Related Issue(s)
List the issue numbers related to this pull request.
Closes #146
Please confirm the following checks