Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the follower cannot find the mithril snapshot, it just returns an error
Error: MithrilSnapshot
However, I was hoping we could abstract this failure and return a follower regardless i.e if it cant bootstrap from the snapshot it should return a follower which is consuming from a network.
Maybe i'm wrong and there's an easier cleaner way, but I had to do the following to mimic the behavior described above on the consumer side.
The PR requires the
FollowerConfig
is cloneable for this code to work because of the move.We can just use the below code for now (if there is no other way) and add the suggestions to the follower at a later date or address it soon on the follower side of things.
I could be way off and missing something. Please let me know.