fix: hermes reactor changes requested #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenj
requested review from
Mr-Leshiy,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
Mr-Leshiy
requested changes
Mar 6, 2024
stevenj
changed the title
stevenj
commented
Mar 7, 2024
stevenj
added a commit
that referenced
this pull request
Mar 11, 2024
* add HermesReactor * rename mod * refactor * move hermes runtime extensions host impl to the separate module * move wasi runtime extensions host impl to the separate module * add on cron event impl * add cardano events * add kv-update event * remove reactor * add HermesReactor * add Hermes Event queue types * wip * wip * add InitEvent * add emit_init_event function * update * fix spelling * fix lints * Add hermes app struct * update Statefull trait * update HermesEventQueue impl * refactor wasm::Module * add TargetApp, TargetModule types * add HermesEventExecutionManager * refactor * remove HermesEventExecutionManager * wip * update hermes state and context structs * rename state to runtime_state * wip * wip * fix spelling * fix * update bench * remove uneeded code * wip * wip * fix bench * fix cargo warning * refactor, update runtime state * remove Stateful trait, update runtime extensions state handling * update emiting init event * refactor event queue * refactor * fix fmt * fix spelling * make HermesEventQueue singltone and static instance * fix spelling * fixes * wip * fix: hermes reactor changes requested (#173) * fix(hermes): changes requested for event queue * fix(hermes): Reintroduce mechanism to advise runtime extensions of a new context * fix(hermes): fix code format * update --------- Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s)
List the issue numbers related to this pull request.
Description of Changes
Provide a clear and concise description of what the pull request changes.
Breaking Changes
Describe any breaking changes and the impact.
Screenshots
If applicable, add screenshots to help explain your changes.
Related Pull Requests
If applicable, list any related pull requests.
Please confirm the following checks