Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardano-chain-follower): set_read_pointer now returns None when the requested point is not found #184

Merged
merged 1 commit into from Mar 19, 2024

Conversation

FelipeRosa
Copy link
Contributor

@FelipeRosa FelipeRosa commented Mar 19, 2024

Description

This PR fixes a bug I found while testing the Cardano Runtime Extension.

Calling Follower::set_read_pointer should return Some(point) if the requested point was found on chain (and the follower is now following from that point) and None if the point was not found. The current implementation always returns None.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@FelipeRosa FelipeRosa self-assigned this Mar 19, 2024
@FelipeRosa FelipeRosa marked this pull request as ready for review March 19, 2024 16:50
@FelipeRosa FelipeRosa added the review me PR is ready for review label Mar 19, 2024
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FelipeRosa FelipeRosa merged commit a4c6f5f into main Mar 19, 2024
24 checks passed
@FelipeRosa FelipeRosa deleted the fix/cardano-chain-follower-set-read-pointer-return branch March 19, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants