fix(cardano-chain-follower): set_read_pointer now returns None when the requested point is not found #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug I found while testing the Cardano Runtime Extension.
Calling
Follower::set_read_pointer
should returnSome(point)
if the requested point was found on chain (and the follower is now following from that point) andNone
if the point was not found. The current implementation always returnsNone
.Please confirm the following checks