Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: time module #200

Merged
merged 14 commits into from
Apr 8, 2024
Merged

test: time module #200

merged 14 commits into from
Apr 8, 2024

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Apr 5, 2024

Description

Add wasm test for localtime and clocks modules

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the draft Draft label Apr 5, 2024
@apskhem apskhem added this to the M2: Hermes Foundations milestone Apr 5, 2024
@apskhem apskhem self-assigned this Apr 5, 2024
@apskhem apskhem added review me PR is ready for review and removed draft Draft labels Apr 5, 2024
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not contain tests for all the time API's as required.
They need to be added.
https://github.com/input-output-hk/hermes/tree/feat/verbose-rust-unit-tests/hermes/bin/src/runtime_extensions/wasi/clocks is also time API's.

@apskhem apskhem requested a review from stevenj April 8, 2024 09:26
@stevenj stevenj merged commit 3894281 into feat/verbose-rust-unit-tests Apr 8, 2024
12 of 13 checks passed
@stevenj stevenj deleted the test/time-module branch April 8, 2024 11:14
stevenj added a commit that referenced this pull request Apr 9, 2024
* fix(wasm): Fix running wasm integration tests

* fix(wasm): Make logging work inside the wasm integration tests

* feat(wasm): working hashing integration test

* ci(wasm): align rust builds with cat-ci latest version

* feat(wasm): Add crypto wasm integration tests

* fix(hermes): Re-enable hermes full build after getting wasm integration tests working

* fix(wasm): silence the initial print inside wasm integration tests to prevent issues when running

* fix(wasm): remove unused import after silencing the wasm integration tester

* style(hermes): Fix code format

* fix(spelling): spelling issue

* fix(cbork): Align deny,toml with CI

* fix(wasm): Align deny.toml with CI

* Update hermes/bin/src/runtime_extensions/hermes/crypto/host.rs

Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com>

* Update hermes/bin/src/runtime_extensions/hermes/crypto/host.rs

Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com>

* feat: hermes-cron integration test cases (#199)

* feat(wip): stub hermes-cron integration test cases

* feat: add tests for cron api functions

* fix: compare returned string with expected

* feat(warm): Add Cardano Runtime Extension integration test skeleton (#198)

* feat(wasm): Add Cardano Runtime Extension integration tests skeleton

* feat(wasm): Use pallas to parse blocks in Cardano RTE integration test component

---------

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>

* fix(wasm): remove commented obsolete code

* Update wasm/integration-test/crypto/crypto.c

Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com>

* test: time module (#200)

* feat: initial commit

* feat: simple function

* ci: add test

* test: restructure and add test to localtime

* fix: minor format

* refactor: remove localtime name

* fix: localtime issue

* feat: clocks test

* fix: test warms

* fix: use existing tests

* chore: earthfile tmp

* fix: builder

* fix: remove wall test

* chore: fmtfix

* fix(spelling): add to project words

* fix(wasm): remove generated bindings, try and use autogenerated ones

* chore(wasm): Fix Cardano RTE wasm integration test module (#204)

* fix(hermes): Update rust builders to the latest

---------

Co-authored-by: bkioshn <35752733+bkioshn@users.noreply.github.com>
Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io>
Co-authored-by: Felipe Rosa <felipe.rosa@iohk.io>
Co-authored-by: Apisit Ritreungroj <38898766+apskhem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants