Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ToString impl for Network #202

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

Mr-Leshiy
Copy link
Contributor

Description

Add ToString trait implementation for Network type.
input-output-hk/catalyst-voices#387 (comment)

minikin
minikin previously approved these changes Apr 8, 2024
cong-or
cong-or previously approved these changes Apr 8, 2024
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this PR be reduced to just the changes to cardano-chain-follower and none of the other stuff in here, like Rust builder versions in earthly or integration test stuff.

@stevenj stevenj merged commit 5a814ce into main Apr 8, 2024
13 of 19 checks passed
@stevenj stevenj deleted the feat/network_to_string branch April 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants