Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify the markdown check from local to call markdown check in catalyst-ci #29

Merged
merged 5 commits into from Dec 7, 2023
Merged

fix: modify the markdown check from local to call markdown check in catalyst-ci #29

merged 5 commits into from Dec 7, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 7, 2023

Description

Modify the markdown check from local to call markdown check in catalyst-ci

Related Issue(s)

Closes #26

Description of Changes

  • rename markdown-check to check-markdown
  • remove local reference in check-markdown
  • update catalylst-ci version for check-markdown and markdown-check-fix
  • Rename the rules for markdownlint-disable
  • fix comments
  • remove markdown-check github action

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn added the enhancement New feature or request label Dec 7, 2023
@bkioshn bkioshn self-assigned this Dec 7, 2023
@bkioshn bkioshn requested a review from stevenj December 7, 2023 08:11
stevenj
stevenj approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 9acfec0 into main Dec 7, 2023
17 checks passed
@stevenj stevenj deleted the fix/markdown-check branch December 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj approved these changes

Assignees

@bkioshn bkioshn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Modify the markdown check from local to call markdown check in catalyst-ci
2 participants
@bkioshn @stevenj