Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cardano-node-follower): Crate API design #33

Merged
merged 15 commits into from Jan 4, 2024

Conversation

FelipeRosa
Copy link
Contributor

@FelipeRosa FelipeRosa commented Dec 7, 2023

This PR adds some code to the cardano-chain-follower that roughly defines the crate's API. I also added some examples, which don't work because there's no implementation yet.

Closes #12.

@FelipeRosa FelipeRosa self-assigned this Dec 7, 2023
@FelipeRosa FelipeRosa force-pushed the cardano-chain-follower-api-design branch 2 times, most recently from 3acc75c to 7f69c7a Compare December 7, 2023 23:32
@FelipeRosa FelipeRosa force-pushed the cardano-chain-follower-api-design branch 5 times, most recently from a38df14 to 73a21c9 Compare December 8, 2023 04:04
@FelipeRosa FelipeRosa force-pushed the cardano-chain-follower-api-design branch 7 times, most recently from 819dd93 to 6276275 Compare December 15, 2023 03:34
@FelipeRosa FelipeRosa changed the title chore: cardano-node-follower crate API design chore(cardano-node-follower): Crate API design Dec 15, 2023
@FelipeRosa FelipeRosa force-pushed the cardano-chain-follower-api-design branch 4 times, most recently from db18905 to 1f5233a Compare December 18, 2023 13:26
@FelipeRosa FelipeRosa marked this pull request as ready for review December 20, 2023 14:47
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit f3f8ddc into main Jan 4, 2024
19 checks passed
@stevenj stevenj deleted the cardano-chain-follower-api-design branch January 4, 2024 07:29
apskhem pushed a commit that referenced this pull request Jan 4, 2024
* chore: cardano-node-follower crate API design

* chore: allow Blue Oak license (need for minicbor crate)

* chore: drop node-to-client support and make rollback chain update return a block

* feat: Add chain follower config and builder

* chore: Remove chain follower crate example (hard to keep up to date)

* chore: Remove chain follower struct fields (implementation specific)

* feat: Add chain follower block fetch methods

* chore: Add fetch block and fetch block range examples

* chore: Fix lint and fmt

* chore: Add chain reader struct and refactor some methods

* chore: Add words to cspell project dictionary

* chore: fix fmt

* chore: Change read_block point type

* chore: Fix lint

* chore: Update rust CI version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants