Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add codeowners #5

Merged
merged 3 commits into from Oct 16, 2023
Merged

feat: add codeowners #5

merged 3 commits into from Oct 16, 2023

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Oct 16, 2023

Description

Add code owners

Breaking Changes

none

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@minikin minikin self-assigned this Oct 16, 2023
@minikin minikin added this to the M1: Open Source Activation milestone Oct 16, 2023
@minikin minikin enabled auto-merge (squash) October 16, 2023 10:15
cong-or
cong-or approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit abd9e3d into main Oct 16, 2023
3 checks passed
@minikin minikin deleted the feature/add-codeowners branch October 16, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cong-or cong-or cong-or approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@minikin minikin

Labels
None yet
Projects
Catalyst
Status: ✅ Done
Milestone
M1: Open Source Activation
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minikin @cong-or