New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Adds notes on Hermes packaging requirements #71
Conversation
fb4a642
to
52bc338
Compare
7b95375
to
f59a2f3
Compare
713d4ba
to
376217a
Compare
move diagram around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome !
But I have a question about private and public data, maybe it make sense to rename directories to the var/public
and var/private
instead of var/data
, var/www
?
So it will make it more clear and from the packaging perspective we will don't care what exact data should be there, we are just managing the scope to it.
cc @stevenj
Thanks! I'm open to renaming the paths, and I considered a similar approach to what you are proposing, but I think that In this case, the context is using HDF5 files as a file-system, so using So, in this case, I would opt for keeping the names as they are, or to find a middle ground. |
…hk/hermes into feat/hermes-packaging-docs
…re served from the app package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the document is clear and understandable 🥳
Description
Adds documentation requirements for packaging Hermes Applications.
Related Issue(s)
List the issue numbers related to this pull request.
#70
Description of Changes
See the generated docs here.
Please confirm the following checks