Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use begin/end logs in the TinyWallet #600

Merged
merged 8 commits into from
Nov 11, 2022
Merged

Use begin/end logs in the TinyWallet #600

merged 8 commits into from
Nov 11, 2022

Conversation

ch1bo
Copy link
Collaborator

@ch1bo ch1bo commented Nov 8, 2022

We were suddenly not receiving any blocks at one time and our logs were not giving away why. This PR shifts the first trace happening, when updating the UTxo of the wallet, before any logic is executed to be directly after the invocation of recvMsgRollForward of the ChainSyncClient

  • CHANGELOG is up to date

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2022-11-11 11:48:02.449695015 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4833 11.88 4.73 0.49
2 5038 13.55 5.37 0.52
3 5241 15.63 6.17 0.55
5 5653 19.17 7.52 0.61
10 6676 29.21 11.39 0.76
45 13854 99.57 38.54 1.84

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO Tx size % max Mem % max CPU Min fee ₳
1 5770 19.63 7.90 0.62

Cost of CollectCom Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 13136 21.36 8.56 0.96
2 13379 36.42 14.75 1.14
3 13773 56.10 22.90 1.37
4 14024 76.70 31.45 1.61

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 9361 8.63 3.53 0.66
2 9494 8.97 3.81 0.67
3 9690 10.19 4.44 0.69
5 10057 12.14 5.49 0.73
10 10257 13.05 5.05 0.74
30 14214 32.03 16.93 1.16
58 15018 35.88 13.61 1.20

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 9330 8.16 3.34 0.65
2 9488 8.94 3.79 0.67
3 9650 9.72 4.24 0.68
5 10024 11.72 5.32 0.72
10 10847 15.62 7.57 0.81
30 14216 32.23 17.00 1.16
43 16329 42.34 22.86 1.38

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 13551 10.93 4.73 0.87
2 13520 11.78 5.34 0.88
3 13622 14.03 6.51 0.91
5 13565 15.96 7.83 0.93
10 13742 23.57 12.23 1.03
50 15302 85.81 47.97 1.86
60 15536 99.74 56.26 2.05

Copy link
Contributor

@v0d1ch v0d1ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! From the PR name I thought you are using bracket function for logging or something similar :)

@ch1bo ch1bo changed the title Use bracketed logs in the TinyWallet Use begin/end logs in the TinyWallet Nov 10, 2022
@github-actions
Copy link

Test Results

257 tests   - 11   251 ✔️  - 11   14m 58s ⏱️ - 17m 14s
  89 suites  -   4       6 💤 ±  0 
    4 files    -   1       0 ±  0 

Results for commit 2af1861. ± Comparison against base commit 4ab0fc8.

This pull request removes 11 tests.
Hydra.TUI.Options ‑ parses --cardano-signing-key option
Hydra.TUI.Options ‑ parses --connect option
Hydra.TUI.Options ‑ parses --network-id option
Hydra.TUI.Options ‑ parses --node-socket option
Hydra.TUI/end-to-end smoke tests ‑ display feedback long enough
Hydra.TUI/end-to-end smoke tests ‑ doesn't allow multiple initializations
Hydra.TUI/end-to-end smoke tests ‑ starts & renders
Hydra.TUI/end-to-end smoke tests ‑ supports the full Head life cycle
Hydra.TUI/end-to-end smoke tests ‑ supports the init & abort Head life cycle
Hydra.TUI/text rendering errors ‑ should show not enough fuel message and suggestion
…

@ch1bo ch1bo requested a review from ffakenz November 11, 2022 15:03
@ch1bo ch1bo merged commit 8216555 into master Nov 11, 2022
@ch1bo ch1bo deleted the ensemble/wallet-logs branch November 11, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants