Skip to content

Commit

Permalink
Try to fix the logs display
Browse files Browse the repository at this point in the history
  • Loading branch information
v0d1ch committed Mar 17, 2023
1 parent 3d1c988 commit bbe90bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hydra-node/src/Hydra/Logging.hs
Expand Up @@ -104,7 +104,7 @@ withTracerOutputTo ::
IO a
withTracerOutputTo hdl namespace action = do
msgQueue <- newTBQueueIO @_ @(Envelope msg) defaultQueueSize
withAsync (writeLogs msgQueue) $ \_ ->
withAsync (writeLogs msgQueue `finally` flushLogs msgQueue) $ \_ ->
action (tracer msgQueue) `finally` flushLogs msgQueue

This comment has been minimized.

Copy link
@ch1bo

ch1bo Mar 17, 2023

Member

@v0d1ch Have you tried with only the upper finally?

This comment has been minimized.

Copy link
@v0d1ch

v0d1ch Mar 17, 2023

Author Contributor

Yeah,,,locally it works fine but on CI 💥

This comment has been minimized.

Copy link
@ch1bo

ch1bo Mar 17, 2023

Member

At least it's consistently failing :/

This comment has been minimized.

Copy link
@v0d1ch

v0d1ch Mar 17, 2023

Author Contributor

I'll try to run github actions locally and see if I can reproduce it.

This comment has been minimized.

Copy link
@ch1bo

ch1bo Mar 17, 2023

Member

I don't think that this will work. I suspect the problem is not github, but that the github runner does have just the right slowness to exhibit this problem.

This comment has been minimized.

Copy link
@v0d1ch

v0d1ch Mar 17, 2023

Author Contributor

I ended up using threadDelay in hydra-node and saw some arguments missing. Hopefully next run will be green.

where
tracer queue =
Expand Down

0 comments on commit bbe90bf

Please sign in to comment.