New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial offline mode ADR #1012
Initial offline mode ADR #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments left, I think we could probably pair or work in team on this ADR to speed up the feedback loop
Thank you! Taking a look now. Making some initial adjustments based on feedback, will message about pairing. Sounds good to me |
@cardenaso11 Do you want more feedback on this? Is it ready for review, or do you want to make the ADR part of the PR introducing the feature? |
Follow-up discussion outcome:
|
@cardenaso11 I would like to move this forward, I think the off-line ADR is in good shape and it's in |
Absolutely, thanks a ton. I'd done that locally but think I had not pushed it |
1b09019
to
5635c00
Compare
5635c00
to
c9b2a37
Compare
GitHub UI somehow rebased like 3 times instead of one for some reason, but either way, removed the other ADR. I also added the edits based on our meeting, let me know if anything else would help. Thanks a ton, @abailly-iohk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cardenaso11 This looks good to me. Not sure if we want to specify exactly how to get to the open Head with this initial utxo we will have as the argument to hydra-node and bypass Commit
. Perhaps this would be too much information for an adr and can be left for the implementation.
@cardenaso11 Apart from some minor comments, we are good to go :) |
Great! Let me know if there's anything else remaining on this ADR to get merged, in the meantime I am gonna make sure the actual cleaned up implementation branch is reviewable for you guys by Monday. Thanks a ton! |
@cardenaso11 Seems like you need to add your handle to the |
add cardenaso11 (self) to authors.yaml
Making this draft publicly visible before the full PR etc, so everyone can see what to prepare for ahead of time. The current status of the implementation, is that it is nearing completion.
This ADR is for support for an offline mode, for the hydra-node target. SundaeSwap intends to contribute these patches upstream. Feedback is welcome, if there are any questions or suggestions or problems.