-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest protocol parameters from node 8.1.2 #1122
Conversation
@matiwinnetou It's hard to track the evolution of this file and ensures it stays in sync with the latest node parameters. I think we should rather modify the demo scripts to extract the file from the cardano-node, modify it on the fly with the needed changes to have 0 fees, and use that instead of committing it. Let's merge this change as is and then plan to update the scripts. |
@matiwinnetou Tests are failing, seems like your changes to pparams had unforeseen side effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some values are wrong, I think that's what prevent the benchmarks and ETE tests from running
"txFeePerByte": 0, | ||
"utxoCostPerWord": 34488, | ||
"utxoCostPerByte": 4310 | ||
"txFeeFixed": 155381, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value must be 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, I was thinking the default should be main-net costs.
"utxoCostPerWord": 34488, | ||
"utxoCostPerByte": 4310 | ||
"txFeeFixed": 155381, | ||
"txFeePerByte": 44, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too
"utxoCostPerByte": 4310 | ||
"txFeeFixed": 155381, | ||
"txFeePerByte": 44, | ||
"utxoCostPerByte": 4310, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
"txFeeFixed": 155381, | ||
"txFeePerByte": 44, | ||
"utxoCostPerByte": 4310, | ||
"utxoCostPerWord": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this null
and not 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change this to 0 but node actually returns null. 8.1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
I can confirm changing the values of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiwinnetou There's still a parameter that is null
instead of 0
"txFeeFixed": 155381, | ||
"txFeePerByte": 44, | ||
"utxoCostPerByte": 4310, | ||
"utxoCostPerWord": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this null
and not 0?
The demo's project protocol parameters is old and incompatible with Hydra 0.13, this a new one which has been tested to work correctly.