-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --ledger-genesis hydra-node argument #863
Conversation
Test Results318 tests +10 312 ✔️ +10 19m 35s ⏱️ -51s Results for commit 3c05590. ± Comparison against base commit c77d536. This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
ed9f7e6
to
f02a619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Some minor things, but duplicated CHANGELOG entry and the computeStabilityWindow
is something that must be changed or clarified.
1e4be55
to
ac75c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments remaining
53ded6f
to
bdbd15a
Compare
bdbd15a
to
76f6383
Compare
Remove duplicate entry in changelog Use property in GeneratorSpec
76f6383
to
3ea7582
Compare
3ea7582
to
3c05590
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed some minor things in a commit myself. Approved now.
Why
We don't really need to provide this file since values needed can be queried from cardano-node.
What
Issue a query to cardano-node to fetch the
GenesisParameters
and then convert those to ledgerGlobals
used when applying transactions to L2 ledger.