-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version all the things #934
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
Test Results313 tests - 1 307 ✔️ - 1 20m 18s ⏱️ - 1m 9s Results for commit 519b32f. ± Comparison against base commit c60d016. This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
5946cbb
to
cea2daf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Had some must-check comments on the connect default and other suggestions.
b3cde3d
to
74880de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can approve in principle, there are still some redundant imports and maybe you want to not undo the re-export.
74880de
to
1d06609
Compare
Move --version option validation from EndToEndSepc to OptionsSpec
ef10993
to
519b32f
Compare
The hydra-tui tool does not have a version option.
Before the PR:
After: