Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version all the things #934

Merged
merged 7 commits into from
Jun 21, 2023
Merged

Version all the things #934

merged 7 commits into from
Jun 21, 2023

Conversation

pgrange
Copy link
Contributor

@pgrange pgrange commented Jun 15, 2023

The hydra-tui tool does not have a version option.

Before the PR:

$ ./hydra-tui --version
Invalid option `--version'

Usage: hydra-tui [-c|--connect ARG] [--node-socket FILE]
                 [--mainnet | --testnet-magic NATURAL]
                 [-k|--cardano-signing-key FILE]

After:

$ ./hydra-tui --version
0.10.0-c1baa8f03caeda60d5a432150b54921687783392

  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-06-20 18:24:26.54535366 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 2212a4ee618434b9b2f366d7c330dbdfb5c7072e793a850fd0de6ddd 4294
νCommit 69e1ccf9ad73dc6d37a5bc8de5aec86f3c4c1710fe5fd334e0e16b18 2124
νHead 8ae095dca4d14a1b8edffb37faa6c84ec60340fbf389a62f027e0b76 9355
μHead 33642a45c7fbb955ce1704ef09229bb211bf9af9980530db28c6aafe* 4148
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4742 13.82 5.43 0.51
2 4947 16.89 6.62 0.55
3 5152 19.29 7.52 0.59
5 5562 22.12 8.51 0.64
10 6586 34.87 13.35 0.82
37 12124 98.39 37.30 1.75

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 596 14.98 5.74 0.34
2 787 19.57 7.70 0.40
3 972 24.66 9.84 0.46
5 1351 36.15 14.59 0.61
10 2290 71.73 28.85 1.04
13 2835 98.11 39.18 1.35

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 815 27.76 10.78 0.49
2 114 1136 43.42 16.99 0.67
3 170 1455 62.16 24.49 0.89
4 225 1774 81.81 32.37 1.12

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 640 18.58 8.31 0.39
2 805 19.97 9.56 0.42
3 969 21.67 10.94 0.45
5 1299 24.46 13.45 0.50
10 1463 25.42 11.04 0.50
50 8725 87.17 69.99 1.74

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 676 24.77 10.63 0.46
2 841 26.06 11.84 0.48
3 1006 28.20 13.38 0.52
5 1328 31.20 15.95 0.58
10 2161 39.77 22.80 0.73
45 7938 99.74 70.74 1.82

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4854 22.40 9.38 0.61
2 5034 32.52 13.58 0.73
3 5496 53.59 22.93 0.99
4 5818 73.47 31.59 1.23
5 5996 90.34 38.77 1.42

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4764 8.66 3.57 0.46
5 1 57 4800 10.06 4.39 0.47
5 5 285 4945 15.64 7.69 0.55
5 10 569 5119 22.61 11.82 0.64
5 20 1140 5485 36.56 20.07 0.83
5 30 1703 5839 50.52 28.33 1.02
5 40 2279 6205 64.49 36.60 1.21
5 50 2842 6563 78.46 44.87 1.40
5 65 3698 7104 99.42 57.28 1.68

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Test Results

313 tests   - 1   307 ✔️  - 1   20m 18s ⏱️ - 1m 9s
106 suites ±0       6 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 519b32f. ± Comparison against base commit c60d016.

This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.
Hydra.Options/Hydra Node RunOptions ‑ parses --version flag as a parse error
Test.EndToEnd/End-to-end on Cardano devnet/hydra-node executable ‑ display proper semantic version given it is passed --version argument
Test.EndToEnd/End-to-end on Cardano devnet/single party hydra head ‑ can submmit a timed tx
Hydra.Options/Hydra Node RunOptions ‑ flag --version returns version with base version from cabal
Test.EndToEnd/End-to-end on Cardano devnet/single party hydra head ‑ can submit a timed tx

♻️ This comment has been updated with latest results.

@pgrange pgrange marked this pull request as ready for review June 15, 2023 10:08
@pgrange pgrange force-pushed the version_all_the_things branch 2 times, most recently from 5946cbb to cea2daf Compare June 15, 2023 14:29
@ch1bo ch1bo requested review from ch1bo and v0d1ch and removed request for ch1bo June 16, 2023 09:41
Copy link
Member

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Had some must-check comments on the connect default and other suggestions.

hydra-node/test/Hydra/OptionsSpec.hs Outdated Show resolved Hide resolved
hydra-tui/src/Hydra/TUI/Options.hs Show resolved Hide resolved
hydra-tui/test/Hydra/TUI/OptionsSpec.hs Show resolved Hide resolved
hydra-tui/test/Hydra/TUI/OptionsSpec.hs Outdated Show resolved Hide resolved
nix/hydra/project.nix Outdated Show resolved Hide resolved
@pgrange pgrange force-pushed the version_all_the_things branch 2 times, most recently from b3cde3d to 74880de Compare June 19, 2023 09:15
Copy link
Member

@ch1bo ch1bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve in principle, there are still some redundant imports and maybe you want to not undo the re-export.

hydra-node/test/Hydra/OptionsSpec.hs Outdated Show resolved Hide resolved
hydra-node/test/Hydra/OptionsSpec.hs Outdated Show resolved Hide resolved
hydra-node/test/Hydra/OptionsSpec.hs Outdated Show resolved Hide resolved
hydra-node/test/Hydra/OptionsSpec.hs Show resolved Hide resolved
@pgrange pgrange merged commit a55a01c into master Jun 21, 2023
22 checks passed
@pgrange pgrange deleted the version_all_the_things branch June 21, 2023 07:17
@ch1bo ch1bo added this to the 0.11.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants