Provide PrimMonad for IOSim and add stToIO to MonadST #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Feb 13, 2024
io-sim/io-sim.cabal
Outdated
| @@ -81,6 +81,7 @@ library | |||
| containers, | |||
| deepseq, | |||
| nothunks, | |||
| primitive, >=0.7 && <0.10 | |||
There was a problem hiding this comment.
Suggested change
| primitive, >=0.7 && <0.10 | |
| primitive >=0.7 && <0.10, |
coot
added
io-classes
dcoutts
force-pushed
the
dcoutts/primitive-monad
branch
from
72585be
to
ca107c0
Compare
coot
approved these changes
Feb 14, 2024
Having IOSim be an instance of PrimMonad (and thus MonadPrim) opens up access to (almost) all of the functionality from the primitive package: including arrays, prim arrays, byte arrays, poiters etc. The only thing from the primitive package that definately will not work is Data.Primitive.MVar, i.e. real MVars. And then also use this to make MonadST a lot simpler. By using the PrimState type family we can express the type of stToIO properly: stToIO :: MonadST m => ST (PrimState m) a -> m a whereas using withLiftST was very tricky.
dcoutts
force-pushed
the
dcoutts/primitive-monad
branch
from
234e644
to
eff1362
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having IOSim be an instance of PrimMonad (and thus MonadPrim) opens up access to (almost) all of the functionality from the primitive package: including arrays, prim arrays, byte arrays, poiters etc.
The only thing from the primitive package that definately will not work is Data.Primitive.MVar, i.e. real MVars.
And then also use this to make MonadST a lot simpler. By using the PrimState type family we can express the type of stToIO properly:
whereas using withLiftST was very tricky.