-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io-sim 1.0.0.0 #60
Merged
Merged
io-sim 1.0.0.0 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3255ba1
to
81a15aa
Compare
a9aa0b4
to
2001e8e
Compare
2001e8e
to
44e48bb
Compare
44e48bb
to
319f522
Compare
bolt12
approved these changes
Apr 14, 2023
30169e1
to
9e7b0ca
Compare
Tested with:
|
9 tasks
They all have been deprecated for a very long time.
One hidden change is adding missing `EventThreadStatus` in `IOSim`.
Only keep 'Control.Monad.IOSim' as public module. In 'ouroboros-network' we imported 'Control.Monad.IOSim.Types' just to have access to `ThreadId` type constructor, but this is already available by virtue of the associated type alias.
We still need to export the internal `execReadTVar` because `ouroboros-consensus` has a very non-standard `StrictMVar`.
This is not tested on CI, and it compiles with benign warnings.
Listing authors & maintains in alphabetic order (by name).
Also include the README.md and CHANGELOG.md in dist bundle created by `cabal`.
We provide READMEs.
Following the Cardano Engineering Handbook.
Expose MonadTraceSTM methods from `Control.Monad.Class.MonadSTM`, otherwise the methods are only documented in the internal module `Control.Monad.Class.MonadSTM.Internal`!
It's exposed as a method of the `MoandInspectSTM`.
They are exported and reused in `io-sim`.
Except of `io-classes-mtl` which is still an experimental. Also update `CHANGELOG` files.
9e7b0ca
to
59c6ca7
Compare
That's the latest version supported by hackage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #57 to be merged first.