Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict MVars with invariant checking #74

Merged
merged 5 commits into from
May 11, 2023

Conversation

jorisdral
Copy link
Contributor

@jorisdral jorisdral commented Mar 14, 2023

Part of #34.

#72 provided a new strict-mvar packages that implements strict MVars without invariant checking. This is a follow-up PR that adds strict MVars with invariant checking in a separate module in the strict-mvar package.

@jorisdral jorisdral added the enhancement New feature or request label Mar 14, 2023
@jorisdral jorisdral self-assigned this Mar 14, 2023
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch 5 times, most recently from 19ea4c6 to 62f0244 Compare April 3, 2023 14:42
@jorisdral jorisdral marked this pull request as ready for review April 3, 2023 14:43
@jorisdral jorisdral requested review from a team, coot and dcoutts April 3, 2023 14:43
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch from 62f0244 to 39f8f31 Compare April 10, 2023 16:00
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch from 39f8f31 to 53ecd0a Compare April 18, 2023 15:30
@jorisdral jorisdral requested a review from coot April 18, 2023 16:09
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch 2 times, most recently from df79d06 to db22d19 Compare April 20, 2023 08:15
@coot coot mentioned this pull request Apr 20, 2023
1 task
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch from db22d19 to 75e10c7 Compare April 24, 2023 09:19
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch 2 times, most recently from 29f9e6b to c21a53c Compare April 24, 2023 10:41
@jorisdral jorisdral requested a review from coot April 24, 2023 12:01
@jorisdral jorisdral force-pushed the jdral/strict-mvar-with-invariant branch from c21a53c to 1c84274 Compare April 28, 2023 09:39
@jorisdral jorisdral requested review from coot and removed request for coot May 10, 2023 09:41
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisdral jorisdral added this pull request to the merge queue May 11, 2023
Merged via the queue into main with commit ec20229 May 11, 2023
13 checks passed
@jorisdral jorisdral deleted the jdral/strict-mvar-with-invariant branch May 11, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants