Skip to content

Commit

Permalink
Merge pull request #60 from Zeegomo/add-info-on-errors
Browse files Browse the repository at this point in the history
Add response in errors
  • Loading branch information
Mikhail Zabaluev committed Mar 2, 2021
2 parents 21f7c09 + 5880bf5 commit bba3db3
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions src/github/mod.rs
Expand Up @@ -15,7 +15,10 @@ use sha1::Digest as _;
#[derive(Debug, Error)]
pub enum GitHubApiError {
#[error("could not deserialize response")]
CannotDeserialize(#[from] serde_json::Error),
CannotDeserialize {
error: serde_json::Error,
response: String,
},
#[error("could not send reqeuest")]
RequestError(#[from] reqwest::Error),
#[error("cannot find release with version: {0}")]
Expand Down Expand Up @@ -269,8 +272,12 @@ impl GitHubApi {

pub fn describe_releases(&self) -> Result<CachedReleases, GitHubApiError> {
let response_text = self.get("releases")?.text()?;
let releases: Vec<ReleaseDto> =
serde_json::from_str(&response_text).map_err(GitHubApiError::CannotDeserialize)?;
let releases: Vec<ReleaseDto> = serde_json::from_str(&response_text).map_err(|error| {
GitHubApiError::CannotDeserialize {
error,
response: response_text,
}
})?;
Ok(CachedReleases::new(
releases
.iter()
Expand Down

0 comments on commit bba3db3

Please sign in to comment.