Skip to content

Commit

Permalink
fix: adds cancel posthog analytics for confirmation screen
Browse files Browse the repository at this point in the history
  • Loading branch information
VanessaPC committed May 7, 2024
1 parent 2b5d9a8 commit 1eb042e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ export const SignTransaction = (): React.ReactElement => {
return !password;
}, [request, password]);

const onCancel = () => {
analytics.sendEventToPostHog(PostHogAction.SendTransactionConfirmationCancelClick, {
[TX_CREATION_TYPE_KEY]: TxCreationType.External
});
setPreviousView;
};

return (
<Layout title={undefined}>
<div className={styles.passwordContainer}>
Expand All @@ -82,12 +89,7 @@ export const SignTransaction = (): React.ReactElement => {
>
{t('dapp.confirm.btn.confirm')}
</Button>
<Button
onClick={setPreviousView}
color="secondary"
className={styles.actionBtn}
data-testid="sign-transaction-cancel"
>
<Button onClick={onCancel} color="secondary" className={styles.actionBtn} data-testid="sign-transaction-cancel">
{t('dapp.confirm.btn.cancel')}
</Button>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export const ConfirmTransaction = (): React.ReactElement => {
}, [setSignTxRequest, setDappInfo]);

const onCancelTransaction = () => {
analytics.sendEventToPostHog(PostHogAction.SendTransactionConfirmationCancelClick, {
analytics.sendEventToPostHog(PostHogAction.SendTransactionSummaryCancelClick, {
[TX_CREATION_TYPE_KEY]: TxCreationType.External
});
disallowSignTx(true);
Expand Down
1 change: 1 addition & 0 deletions packages/common/src/analytics/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export enum PostHogAction {
SendClick = 'send | send | click',
SendTransactionDataReviewTransactionClick = 'send | transaction data | review transaction | click',
SendTransactionSummaryConfirmClick = 'send | transaction summary | confirm | click',
SendTransactionSummaryCancelClick = 'send | transaction summary | cancel | click',
SendTransactionConfirmationConfirmClick = 'send | transaction confirmation | confirm | click',
SendTransactionConfirmationCancelClick = 'send | transaction confirmation | cancel | click',
SendTransactionConfirmed = 'send | transaction confirmed',
Expand Down

0 comments on commit 1eb042e

Please sign in to comment.