Skip to content

Commit

Permalink
fix: match the set of strings to the previous confirm click
Browse files Browse the repository at this point in the history
  • Loading branch information
VanessaPC committed May 7, 2024
1 parent a4d929d commit 3f39e7e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const ConfirmTransaction = (): React.ReactElement => {
}, [req]);

const onConfirmTransaction = () => {
analytics.sendEventToPostHog(PostHogAction.DappConnectorSendTransactionClick, {
analytics.sendEventToPostHog(PostHogAction.SendTransactionSummaryConfirmClick, {
[TX_CREATION_TYPE_KEY]: TxCreationType.External
});

Expand Down Expand Up @@ -86,7 +86,7 @@ export const ConfirmTransaction = (): React.ReactElement => {
}, [setSignTxRequest, setDappInfo]);

const onCancelTransaction = () => {
analytics.sendEventToPostHog(PostHogAction.DappConnectorCancelTransactionClick, {
analytics.sendEventToPostHog(PostHogAction.SendTransactionConfirmationCancelClick, {
[TX_CREATION_TYPE_KEY]: TxCreationType.External
});
disallowSignTx(true);
Expand Down
4 changes: 1 addition & 3 deletions packages/common/src/analytics/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export enum PostHogAction {
SendTransactionDataReviewTransactionClick = 'send | transaction data | review transaction | click',
SendTransactionSummaryConfirmClick = 'send | transaction summary | confirm | click',
SendTransactionConfirmationConfirmClick = 'send | transaction confirmation | confirm | click',
SendTransactionConfirmationCancelClick = 'send | transaction summary | cancel | click',
SendTransactionConfirmed = 'send | transaction confirmed',
SendAllDoneView = 'send | all done | view',
SendAllDoneViewTransactionClick = 'send | all done | view transaction | click',
Expand Down Expand Up @@ -222,9 +223,6 @@ export enum PostHogAction {
DappConnectorAuthorizeDappDappConnectorBetaClick = 'dapp connector | authorize dapp | dapp connector beta | click',
DappConnectorAuthorizeDappConnectionAlwaysClick = 'dapp connector | authorize dapp | dapp connection | always | click',
DappConnectorAuthorizeDappConnectionOnlyOnceClick = 'dapp connector | authorize dapp | dapp connection | only once | click',
DappConnectorCancelTransactionClick = 'dapp connector | confirm transaction | cancel | click',
DappConnectorSendTransactionClick = 'dapp connector | confirm transaction | confirm | click',

// User
UserWalletProfileIconClick = 'user/wallet profile | profile icon | click',
UserWalletProfileWalletAddressClick = 'user/wallet profile | wallet address | click',
Expand Down

0 comments on commit 3f39e7e

Please sign in to comment.