fix(extension): fixing a test InfoActionContainer

input-output-hk · May 8, 2024 · c3d42e8 · c3d42e8
1 parent 6755b9f
commit c3d42e8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 3 deletions.
diff --git a/...ion-wallet/src/features/dapp/components/confirm-transaction/VotingProceduresContainer.tsx b/...ion-wallet/src/features/dapp/components/confirm-transaction/VotingProceduresContainer.tsx
@@ -58,7 +58,7 @@ export const VotingProceduresContainer = (): React.ReactElement => {
         </Box>
         <VotingProcedures
           data={votingProcedures.map((votingProcedure) =>
-            Wallet.util.mapVotingProceduresToView(votingProcedure, explorerBaseUrl)
+            Wallet.util.mapVotingProcedureToView(votingProcedure, explorerBaseUrl)
           )}
         />
       </Flex>

diff --git a/...components/confirm-transaction/proposal-procedures/__tests__/InfoActionContainer.test.tsx b/...components/confirm-transaction/proposal-procedures/__tests__/InfoActionContainer.test.tsx
@@ -67,6 +67,7 @@ describe('Testing ProposalProceduresContainer component', () => {
     expect(mockInfoAction).toHaveBeenLastCalledWith(
       {
         data: {
+          txDetails: {},
           procedure: {
             anchor: {
               url: anchor.url,

diff --git a/packages/cardano/src/wallet/util/voter.ts b/packages/cardano/src/wallet/util/voter.ts
@@ -68,7 +68,7 @@ type VotingProcedureView = {
   }[];
 };
 
-export const mapVotingProceduresToView = (
+export const mapVotingProcedureToView = (
   votingProcedure: Cardano.VotingProcedures[number],
   explorerBaseUrl: string
 ): VotingProcedureView => {

diff --git a/packages/core/src/ui/components/ActivityDetail/components/TxDetailsVotingProcedures.tsx b/packages/core/src/ui/components/ActivityDetail/components/TxDetailsVotingProcedures.tsx
@@ -19,7 +19,7 @@ export const TxDetailsVotingProcedures = ({
     <TxDetailsGroup title={t('core.activityDetails.votingProcedures')} testId="voting-procedures" withSeparatorLine>
       <VotingProcedures
         data={votingProcedures.map((votingProcedure) =>
-          Wallet.util.mapVotingProceduresToView(votingProcedure, explorerBaseUrl)
+          Wallet.util.mapVotingProcedureToView(votingProcedure, explorerBaseUrl)
         )}
       />
     </TxDetailsGroup>

diff --git a/...core/src/ui/components/ProposalProcedures/ParameterChangeAction/ParameterChangeAction.tsx b/...core/src/ui/components/ProposalProcedures/ParameterChangeAction/ParameterChangeAction.tsx
@@ -20,6 +20,8 @@ export const ParameterChangeAction = ({
   const { economicGroup, governanceGroup, networkGroup, technicalGroup, maxTxExUnits, maxBlockExUnits } =
     protocolParamUpdate;
 
+  // TODO: consider encapsulating it inside the component itself, check if all the translations have the fallback to the parent int provider (LW-9920)
+
   const translations: Types.Translations = {
     txDetails: {
       title: t('core.ProposalProcedure.txDetails.title'),