Skip to content

Commit

Permalink
SCP-5129 Fixed (==) for ReduceAssertionFailed.
Browse files Browse the repository at this point in the history
  • Loading branch information
bwbush committed Mar 15, 2023
1 parent 9d5443c commit 84d65a7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions marlowe/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ Based on audit findings, we annotated Marlowe's Plutus validator with comments i
## SCP-5123: Semantically negative deposits do not withdraw funds from the script

Based on audit findings, we corrected the accounting equation so that negative deposits are treated as zero by the validator. This prevents a negative deposit from removing value from the script's UTxO, which would have left the total value in accounts unequal to the value in the script UTxO.


## SCP-5129: Fixed `(==)` for `ReduceAssertionFailed`

Based on audit finding, we corrected `instance Eq ReduceWarning` so that when a comparison of `ReduceAssertionFailed` to itself yields `True`.
1 change: 1 addition & 0 deletions marlowe/src/Language/Marlowe/Core/V1/Semantics.hs
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,7 @@ instance Eq ReduceWarning where
acc1 == acc2 && p1 == p2 && tn1 == tn2 && a1 == a2 && e1 == e2
(ReduceShadowing v1 old1 new1) == (ReduceShadowing v2 old2 new2) =
v1 == v2 && old1 == old2 && new1 == new2
ReduceAssertionFailed == ReduceAssertionFailed = True
_ == _ = False


Expand Down

0 comments on commit 84d65a7

Please sign in to comment.