Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP-5054 Handle epoch-boundary block in chain-indexer tests #497

Merged
merged 4 commits into from Feb 23, 2023
Merged

Conversation

bwbush
Copy link
Collaborator

@bwbush bwbush commented Feb 23, 2023

I upgraded the marlowe-chain-indexer vs cardano-db-sync comparison test to account for epoch-boundary blocks (EBBs) on mainnet. I also added a comment in the PostgreSQL code noting the existence of EBBs.

The comparison tests at aff3683 passed (for blocks) and are recorded at http://testing.marlowe.run/database/. We still have unrelated comparison failures for mainnet only.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@bwbush bwbush self-assigned this Feb 23, 2023
@bwbush
Copy link
Collaborator Author

bwbush commented Feb 23, 2023

Reviewed in #493.

@bwbush bwbush merged commit bcf93ce into main Feb 23, 2023
@bwbush bwbush deleted the SCP-5054 branch February 23, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant