Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-5286 Adjust default logging configuration for each component and document #542

Merged
merged 11 commits into from Mar 21, 2023

Conversation

jhbertra
Copy link
Contributor

  • Adds --print-log-config option for each runtime service
  • Disables all send recv and database logs by default
  • Adds documentation for the log config.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
    • Reviewer requested

@jhbertra jhbertra requested a review from bwbush March 21, 2023 12:22
@jhbertra jhbertra self-assigned this Mar 21, 2023
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! I think these are appropriate defaults for production deployment. For development and testing, we can turn up the verbosity.

I suppose there is no type-safe way to ensure (via compiler warnings) that we remember to add the correct entries to things like defaultRootSelectorLogConfig if we later expand the logging?

@jhbertra
Copy link
Contributor Author

I suppose there is no type-safe way to ensure (via compiler warnings) that we remember to add the correct entries to things like defaultRootSelectorLogConfig if we later expand the logging?

Alas, no. Our options for this are:

  1. Generate this stuff with template Haskell
  2. Use a row-based approach to specifying selectors instead of GADTs (i.e. extensible Variants and records for selectors and config, respectively).

@jhbertra jhbertra enabled auto-merge March 21, 2023 12:39
@jhbertra jhbertra merged commit d5be0c1 into main Mar 21, 2023
7 checks passed
@jhbertra jhbertra deleted the plt-quieter-logs branch March 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants