Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-5850 Merkleize Inputs query #594

Merged
merged 15 commits into from Jun 2, 2023
Merged

PLT-5850 Merkleize Inputs query #594

merged 15 commits into from Jun 2, 2023

Conversation

jhbertra
Copy link
Contributor

  • Adds a new query to marlowe-contract to merkleize inputs for a contract.
  • Adds a new module for generating a contract with a predetermined input path to be applied to it.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
    • Reviewer requested

@jhbertra jhbertra requested review from nhenin and bwbush May 31, 2023 20:31
@jhbertra jhbertra self-assigned this May 31, 2023
@jhbertra jhbertra force-pushed the plt-5850-get-merkleized-inputs branch 2 times, most recently from 394b123 to aa82f3f Compare June 1, 2023 11:59
@jhbertra jhbertra force-pushed the plt-5850-get-merkleized-inputs branch 2 times, most recently from 3ec9b64 to 580609d Compare June 2, 2023 17:09
bwbush
bwbush reviewed Jun 2, 2023
View reviewed changes
marlowe-runtime/marlowe-tx/Main.hs
@@ -190,6 +200,14 @@ getOptions = execParser $ info (helper <*> parser) infoMod
, showDefault
]

contractQueryPortParser = option auto $ mconcat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment about this in the dependent PR, that we should update the deployment configurations.

@jhbertra jhbertra force-pushed the plt-5850-get-merkleized-inputs branch from 580609d to bc76479 Compare June 2, 2023 18:35
@jhbertra jhbertra merged commit feed5ef into main Jun 2, 2023
10 checks passed
@jhbertra jhbertra deleted the plt-5850-get-merkleized-inputs branch June 2, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

@nhenin nhenin Awaiting requested review from nhenin

Assignees

@jhbertra jhbertra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhbertra @bwbush