Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLT-5854 create by hash #595

Merged
merged 6 commits into from Jun 2, 2023
Merged

PLT-5854 create by hash #595

merged 6 commits into from Jun 2, 2023

Conversation

jhbertra
Copy link
Contributor

@jhbertra jhbertra commented Jun 1, 2023

  • Added option to Create to pass a DatumHash instead of a Contract v
  • Added a --contract-hash option to marlowe-runtime-cli
  • Updated integration tests to exercise new functionality

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
    • Reviewer requested

@jhbertra jhbertra requested review from paluh and bwbush June 1, 2023 20:27
@jhbertra jhbertra self-assigned this Jun 1, 2023
@jhbertra jhbertra force-pushed the plt-5850-get-merkleized-inputs branch from 3ec9b64 to 580609d Compare June 2, 2023 17:09
bwbush
bwbush reviewed Jun 2, 2023
View reviewed changes
marlowe-runtime/marlowe-tx/Main.hs Outdated
@@ -190,6 +200,14 @@ getOptions = execParser $ info (helper <*> parser) infoMod
, showDefault
]

contractQueryPortParser = option auto $ mconcat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update deploy/operables.nix, deploy/nomadTasks.nix, and nix/dev/compose.nix accordingly.

bwbush
bwbush approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice how clean this was.

Please note the comment about updating the marlowe-tx deployment configurations (which now have another socket dependency) in this PR, too.

@jhbertra jhbertra force-pushed the plt-5850-get-merkleized-inputs branch from 580609d to bc76479 Compare June 2, 2023 18:35
Base automatically changed from plt-5850-get-merkleized-inputs to main June 2, 2023 18:41
@jhbertra jhbertra merged commit 8895cd4 into main Jun 2, 2023
162 checks passed
@jhbertra jhbertra deleted the plt-5854-create-by-hash branch June 2, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwbush bwbush bwbush approved these changes

@paluh paluh Awaiting requested review from paluh

Assignees

@jhbertra jhbertra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhbertra @bwbush