Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-6201 Allow tracing to become a true noop #607

Merged
merged 3 commits into from Jun 13, 2023
Merged

Conversation

jhbertra
Copy link
Contributor

  • Make tracing a no-op if the OTEL_EXPORTER_OTLP_ENDPOINT env var is not set (this is not standard, but is convenient in our case).
    • No-op means that the global tracer provider is not initialized and that a noopEventBackend is used, so selectors and fields are never held in memory past creation and are not processed into spans and attributes.
  • Refactor: consolidate duplicated monad stack into a single module (used in all runtime components, web server, and integration tests).
  • Refactor: consolidate tracer initialization to the same place.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
    • Reviewer requested

@jhbertra jhbertra requested review from shlevy and bwbush June 13, 2023 17:52
@jhbertra jhbertra self-assigned this Jun 13, 2023
Copy link
Collaborator

@bwbush bwbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jhbertra jhbertra merged commit 8e3fc52 into main Jun 13, 2023
273 of 274 checks passed
@jhbertra jhbertra deleted the plt-6201-disable-otel branch June 13, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants