New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-7204 Part 2: Dynamic query #697
Conversation
0d87189
to
55b1341
Compare
011da4f
to
3f8c773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but there was too much code in the new package for me to review in great detail and there are no tests in the new package's test suite yet.
How were the golden tests generated and checked for correctness? Are they just to detect regressions?
Finally, can we add a changelog entry to runtime for this. Are there no API or breaking changes?
|
hasql-dynamic-syntax
for AST-based dynamic query generationmarlowe
schema.getPayouts
to usehasql-dynamic-syntax
Pre-submit checklist: